Sunshine
Sunshine copied to clipboard
fix(config): use boolean values instead of strings
Description
Follow up PR for #3544
TODO:
- [ ] ensure legacy strings are properly migrated
Screenshot
Issues Fixed or Closed
Type of Change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Dependency update (updates to dependencies)
- [ ] Documentation update (changes to documentation)
- [ ] Repository update (changes to repository files, e.g.
.github/...)
Checklist
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated the in code docstring/documentation-blocks for new or existing methods/components
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 11.64%. Comparing base (64544e7) to head (f9ad84a).
:warning: Report is 230 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #3550 +/- ##
=========================================
Coverage 11.64% 11.64%
=========================================
Files 93 93
Lines 17302 17302
Branches 8081 8081
=========================================
Hits 2014 2014
- Misses 12808 14694 +1886
+ Partials 2480 594 -1886
| Flag | Coverage Δ | |
|---|---|---|
| Linux | 11.36% <ø> (+0.04%) |
:arrow_up: |
| Windows | 13.05% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more. see 31 files with indirect coverage changes
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!