Sunshine icon indicating copy to clipboard operation
Sunshine copied to clipboard

ci: build all before releasing

Open sitiom opened this issue 3 years ago • 7 comments

Description

Upon creating a new release, all binaries should be available. This should fix https://github.com/LizardByte/Sunshine/discussions/318#discussioncomment-3362357

The https://github.com/softprops/action-gh-release action is used for releasing and the action from this org is no longer used as the action is only run once and not reused elsewhere.

Screenshot

Issues Fixed or Closed

  • Fixes https://github.com/LizardByte/Sunshine/discussions/318#discussioncomment-3362357

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added or updated the docstring/documentation-blocks for new or existing methods/components

sitiom avatar Aug 10 '22 12:08 sitiom

Your PR was set to master, PRs should be sent to nightly. The base branch of this PR has been automatically changed to nightly. Please check that there are no merge conflicts

github-actions[bot] avatar Aug 10 '22 12:08 github-actions[bot]

This does not resolve the issue at hand. The winget workflow is failing even with the .exe present.

ReenigneArcher avatar Aug 10 '22 12:08 ReenigneArcher

This does not resolve the issue at hand. The winget workflow is failing even with the .exe present.

Which shouldn't, and should be a bug in the action if it does so. Perhaps reruns do not work. cc @vedantmgoyal2009

But anyways, this fixes the case where the .exe is not present (which happened on the first run).

sitiom avatar Aug 10 '22 12:08 sitiom

On re-runs, the release object in the GitHub context payload does not get updated, and hence, the action can't find .exe URL.

vedantmgoyal9 avatar Aug 10 '22 13:08 vedantmgoyal9

On re-runs, the release object in the GitHub context payload does not get updated, and hence, the action can't find .exe URL.

Oh alright, that explains it. @ReenigneArcher Should I make a manual update to winget-pkgs for 0.14.1 for a while?

sitiom avatar Aug 10 '22 13:08 sitiom

On re-runs, the release object in the GitHub context payload does not get updated, and hence, the action can't find .exe URL.

Oh alright, that explains it. @ReenigneArcher Should I make a manual update to winget-pkgs for 0.14.1 for a while?

Yes, for now. I don't plan to create another release just to update winget-pkgs.

ReenigneArcher avatar Aug 10 '22 13:08 ReenigneArcher

Ok. https://github.com/microsoft/winget-pkgs/pull/69256

sitiom avatar Aug 10 '22 13:08 sitiom