Sunshine icon indicating copy to clipboard operation
Sunshine copied to clipboard

fix(upnp): Support miniupnpc API version 18 (release 2.2.8)

Open chewi opened this issue 1 year ago • 1 comments

Description

The miniupnpc API has changed slightly. This allows both older and newer versions. The additional arguments are for returning data that Sunshine doesn't need to care about, so nullptr, 0 is sufficient. I have already made the same change to a couple of other projects.

Type of Change

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Dependency update (updates to dependencies)
  • [ ] Documentation update (changes to documentation)
  • [ ] Repository update (changes to repository files, e.g. .github/...)

Checklist

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch must be updated before it can be merged. You must also Allow edits from maintainers.

  • [X] I want maintainers to keep my branch updated

chewi avatar Jun 23 '24 15:06 chewi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 8.95%. Comparing base (90fd371) to head (09b7ac3). Report is 136 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2746      +/-   ##
=========================================
- Coverage    8.95%   8.95%   -0.01%     
=========================================
  Files          94      94              
  Lines       17383   17385       +2     
  Branches     8267    8267              
=========================================
  Hits         1557    1557              
- Misses      12962   12967       +5     
+ Partials     2864    2861       -3     
Flag Coverage Δ
Linux 6.79% <ø> (ø)
Windows 4.16% <ø> (ø)
macOS-12 10.01% <ø> (-0.02%) :arrow_down:
macOS-13 9.92% <ø> (-0.01%) :arrow_down:
macOS-14 10.22% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/upnp.cpp 2.98% <ø> (-0.04%) :arrow_down:

... and 22 files with indirect coverage changes

codecov[bot] avatar Jun 30 '24 23:06 codecov[bot]