Sunshine
Sunshine copied to clipboard
LizardByte
[Linux Pulse/Pipewire] No sink path
Description
Added some logic so it should handle the case of no default audio sink. I do not currently have a setup where there are no audio sinks to test this, and am having encoder issues on my current machine, therefore I marked this as draft until further testing can occur.
Issues Fixed or Closed
- Fixes #226
Type of Change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
Testing Scenarios
- [ ] No sinks on launch (Should create and switch to virtual sink)
- [ ] Has a sink, Uses "play audio on host"
- [ ] Has a sink, Does not use "play audio on host"
I would really like to see this get merged :-) I'm available to help testing the "no sinks on launch" case if it helps.
I would really like to see this get merged :-) I'm available to help testing the "no sinks on launch" case if it helps.
This PR is still in a draft state. Once it's marked ready we can build this version to test.
Per @ABeltramo's request, I've tested this branch on my setup with no sinks, and it works perfectly. As expected, I see this in the logs when I connect:
gow-sunshine-1 | [2022:08:10:17:46:24]: Warning: Couldn't find an active default sink. Continuing with virtual audio only.
So we know it's going through the correct code path. After connecting, audio plays back correctly with no issues. Thanks @Logical-sh !
@zb140 thank you for testing!
@Logical-sh is it possible for you to update your branch with our latest changes? I believe the main thing that changed is the directory of those files changed from sunshine to src. We also now require that branches are up to date before merging (since I learned about branch protection rules).
As far as I know, nothing technical. I have just recently gotten my main dev pc back online and need to re-setup all my dev tools and the repository. I can try to get this sorted out this week!
On Mon, Aug 29, 2022 at 2:24 PM Kyle McNally @.***> wrote:
Is there something blocking the rebase?
— Reply to this email directly, view it on GitHub https://github.com/LizardByte/Sunshine/pull/237#issuecomment-1230761288, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMJ27XVCJZ6ZN2ERTVL6NDV3UFAJANCNFSM52P2VIAQ . You are receiving this because you were mentioned.Message ID: @.***>