Sunshine
Sunshine copied to clipboard
Use C++20.
Description
#2149 was reverted in #2320 and needs to be split into three changes:
- C++20 (this one!)
- UCRT64
- WGC
Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Dependency update (updates to dependencies)
- [ ] Documentation update (changes to documentation)
- [ ] Repository update (changes to repository files, e.g.
.github/...)
Checklist
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added or updated the in code docstring/documentation-blocks for new or existing methods/components
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch must be updated before it can be merged. You must also Allow edits from maintainers.
- [x] I want maintainers to keep my branch updated
Codecov Report
Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.
Project coverage is 6.05%. Comparing base (
9288775) to head (bdf643e).
Additional details and impacted files
@@ Coverage Diff @@
## nightly #2322 +/- ##
==========================================
- Coverage 6.17% 6.05% -0.13%
==========================================
Files 86 86
Lines 17542 17536 -6
Branches 8179 8184 +5
==========================================
- Hits 1083 1061 -22
- Misses 15362 15434 +72
+ Partials 1097 1041 -56
| Flag | Coverage Δ | |
|---|---|---|
| Linux | 4.26% <0.00%> (+<0.01%) |
:arrow_up: |
| Windows | 2.04% <0.00%> (-0.01%) |
:arrow_down: |
| macOS-12 | ? |
|
| macOS-13 | 7.84% <0.00%> (-0.09%) |
:arrow_down: |
| macOS-14 | 8.16% <0.00%> (-0.09%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| src/config.cpp | 3.87% <ø> (-0.63%) |
:arrow_down: |
| src/httpcommon.cpp | 2.12% <ø> (ø) |
|
| src/nvhttp.cpp | 0.92% <ø> (-0.16%) |
:arrow_down: |
| src/platform/linux/cuda.cpp | 1.65% <ø> (ø) |
|
| src/platform/linux/kmsgrab.cpp | 2.30% <ø> (-0.01%) |
:arrow_down: |
| src/rtsp.cpp | 1.34% <ø> (-0.34%) |
:arrow_down: |
| src/stream.h | 0.00% <ø> (ø) |
|
| src/platform/linux/input.cpp | 0.22% <0.00%> (ø) |
|
| src/platform/windows/input.cpp | 0.39% <0.00%> (ø) |
|
| src/platform/windows/misc.cpp | 1.07% <0.00%> (ø) |
|
| ... and 1 more |
AppImage build fails because Ubuntu 20.04 provides only Boost 1.71, which is incompatible with C++20. https://stackoverflow.com/questions/62723053/boost-log-expressions-v1-71-will-not-compile-under-c20
There is a more recent LTS version. Could we drop 20.04? Every other distribution that Sunshine makes builds for provides 1.74 or higher, even Debian 11.
What wonderful timing! CI passes on my fork.
https://github.com/tez011/Sunshine/actions/runs/8486729110
depends on #2327
depends on #2327
Merged.
Is there anything else in this pull request I should handle before it's able to be merged?
Just needs testing and approval. It will be after v0.23.0.
Hi! Just waiting for testing/approval results for this pull request. This first change is fairly small so I'm hoping there aren't too many obstacles!
@tez011 sorry for the delays. We have a lot of open PRs. It might take a little bit before the other approvals come in. I think we are going to try to put out another patch to get a few things fixed before merging these bigger ones.
In the meantime, can you rebase your branch on top of the latest nightly?
@ReenigneArcher LGTM