Sunshine icon indicating copy to clipboard operation
Sunshine copied to clipboard

style: adjust clang-format rules

Open ReenigneArcher opened this issue 1 year ago • 5 comments

Description

Adjust clang-format rules, mostly to adjust break after return type behavior.

Screenshot

Issues Fixed or Closed

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Dependency update (updates to dependencies)
  • [ ] Documentation update (changes to documentation)
  • [x] Repository update (changes to repository files, e.g. .github/...)

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch must be updated before it can be merged. You must also Allow edits from maintainers.

  • [ ] I want maintainers to keep my branch updated

ReenigneArcher avatar Feb 27 '24 22:02 ReenigneArcher

See https://github.com/LizardByte/Sunshine/actions/runs/8072315274/job/22053784930 for all changes that will be applied when this PR is ready to merge.

ReenigneArcher avatar Feb 27 '24 22:02 ReenigneArcher

I made a proposal of changes in: https://github.com/LizardByte/Sunshine/pull/2623

Hazer avatar Jun 01 '24 01:06 Hazer

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 8.98%. Comparing base (5cea1e1) to head (90f6aec). Report is 63 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2186   +/-   ##
======================================
  Coverage    8.98%   8.98%           
======================================
  Files          95      95           
  Lines       17304   17304           
  Branches     8232    8232           
======================================
  Hits         1555    1555           
+ Misses      12884   12881    -3     
- Partials     2865    2868    +3     
Flag Coverage Δ
Linux 6.78% <ø> (ø)
Windows 4.16% <ø> (ø)
macOS-12 10.09% <ø> (ø)
macOS-13 10.01% <ø> (ø)
macOS-14 10.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

codecov[bot] avatar Jun 01 '24 14:06 codecov[bot]

Could we get this curly bracket on a new line? It looks very ugly in my opinion. Moving it still looks ugly, but less so... image

FrogTheFrog avatar Jul 07 '24 16:07 FrogTheFrog