Windows uninstaller does not remove Start Menu shortcut

[sitiom]

Describe the Bug

The start menu shortcut does not get removed on uninstallation of Sunshine:

Expected Behavior

It should get removed on uninstallation.

Additional Context

No response

Sunshine Host Operating System and Version

Windows 11

Architecture

64 bit

Sunshine Version

0.14.0

GPU Type

Nvidia

GPU Model

GeForce RTX 2070 SUPER

GPU Driver/Mesa Version

512.95

Capture Method (Linux Only)

No response

[ReenigneArcher]

This is a note for myself:

Adding CPACK_NSIS_DELETE_ICONS_EXTRA "should" resolve this.

https://cmake.org/cmake/help/latest/cpack_gen/nsis.html#variable:CPACK_NSIS_DELETE_ICONS_EXTRA

Should probably also use CPACK_NSIS_CREATE_ICONS_EXTRA instead of CPACK_NSIS_CREATE_ICONS here: https://github.com/SunshineStream/Sunshine/blob/master/CMakeLists.txt#L496

Reference for adding multiple entries to start menu and desktop: https://stackoverflow.com/questions/2640760/creating-windows-desktop-icon-in-cmake-cpack-nsis

[github-actions[bot]]

This issue has been fixed and will be available in the next release.