Sunshine icon indicating copy to clipboard operation
Sunshine copied to clipboard

Change LICENSE from GPL v3 to AGPL v3

Open ReenigneArcher opened this issue 3 years ago • 58 comments

Description

Some commercial companies are utilizing modified versions of Sunshine without publishing the source code. Using GPL v3 could be argued that it's still distribution even though it's a network asset, as the end user has a high level of control over the virtual machine. Changing to the AGPL v3 license will remove any doubt.

The AGPL V3 license is a strong copyleft license that enforces open source on all components derived from any previous work. It closes the server-side loophole, where the source code isn’t made available if the software isn’t released. AGPL defines a user as anyone who accesses the server-side application if it is public-facing. For applications that reside inside the organization’s network, AGPL does not trigger the release of the source code.

https://snyk.io/learn/agpl-license/

This PR requires approval from previous contributors before being merged. Contributors tagged in this PR, please comment with "I approve" or "I reject"

Approval Tracking List

CPP contributors:

  • [x] @ReenigneArcher
  • [x] @gamozolabs
  • [x] @arnerak
  • [x] @felipejfc
  • [x] @cgutman
  • [x] @psyke83
  • [x] @theofficialgman
  • [x] @TheElixZammuto
  • [x] @WisdomCode
  • [x] @JacekJagosz
  • [x] @KiralyCraft
  • [x] @nowrep
  • [x] @abusse
  • [ ] @loki-47-6F-64
  • [ ] @notentered
  • [x] @guanzhangrtk
  • [ ] @PapyKahan

Non CPP contributors:

  • [x] @exalented
  • [x] @hadicharara
  • [x] @okkiv
  • [x] @Doomsdayrs
  • [x] @luk1337
  • [x] @angelnu
  • [x] @hadogenes
  • [x] @sethicis
  • [x] @exetico
  • [x] @diadatp
  • [x] @alvaromunoz
  • [ ] @jorys-paulin

Contributors with un-merged changes (not in master branch yet):

  • [x] @ABeltramo
  • [x] @Logical-sh
  • [x] @thatsysadmin
  • [x] @sitiom
  • [x] @HomerSp

In process PRs (not yet merged into any branch):

  • [x] @cazzoo
  • [x] @KarlVogel
  • [x] @caioavidal
  • [x] @TheChoconut
  • [x] @arifwn
  • [x] @mariotaku
  • [x] @YourSandwich
  • [x] @istori1 (signed CLA)

ReenigneArcher avatar May 06 '22 19:05 ReenigneArcher

I approve

Will this change affect also the original Sunshine repo/source?

ABeltramo avatar May 06 '22 20:05 ABeltramo

I approve

exalented avatar May 06 '22 20:05 exalented

Will this change affect also the original Sunshine repo/source?

No; however if everyone on this list agrees, it already encompasses all the original contributors so the change could be made to Loki's repo as well.

Also, this will only affect future releases, anything already released would remain under GPL v3.

ReenigneArcher avatar May 06 '22 20:05 ReenigneArcher

I approve ! Go free software!

hadicharara avatar May 06 '22 20:05 hadicharara

Btw which proprietary versions are we talking about?

hadicharara avatar May 06 '22 20:05 hadicharara

I approve!

Logical-sh avatar May 06 '22 20:05 Logical-sh

Btw which proprietary versions are we talking about?

This is the one that sparked this request: https://www.oneplay.in/ They have since published the source: https://github.com/astar10239/OPlayStreamingServer/tree/dev

Someone has speculated to me that this one is also using Sunshine: https://shrine.app/ I have no evidence to say that is true or not.

Then of course, there is Maximum settings: https://maximumsettings.com/ They have also published source code: https://github.com/Sean-MaximumSettings/Maxximizer-Sunshine

ReenigneArcher avatar May 06 '22 20:05 ReenigneArcher

I approve.

psyke83 avatar May 06 '22 20:05 psyke83

I approve!

okkiv avatar May 06 '22 20:05 okkiv

I approve

arnerak avatar May 06 '22 20:05 arnerak

I approve!

gamozolabs avatar May 06 '22 20:05 gamozolabs

I approve

cgutman avatar May 06 '22 21:05 cgutman

I approve

felipejfc avatar May 06 '22 22:05 felipejfc

I approve.

theofficialgman avatar May 06 '22 22:05 theofficialgman

How dare they profit off our work and give nothing back?

Parasites they be.

I approve!

Doomsdayrs avatar May 06 '22 22:05 Doomsdayrs

I approve!

You have the OK from me!

thatsysadmin avatar May 06 '22 23:05 thatsysadmin

I approve!

luk1337 avatar May 06 '22 23:05 luk1337

I approve!

sitiom avatar May 07 '22 01:05 sitiom

I approve!

nowrep avatar May 07 '22 05:05 nowrep

While I approve, we must also look into how this affects linking against GPL libraries and other compatibility issues we may encounter down the road; Looks like linking a GPL thing against AGPL library doesn't work, though otherwise it should be fine - So full steam ahead

KiralyCraft avatar May 07 '22 06:05 KiralyCraft

I approve

angelnu avatar May 07 '22 08:05 angelnu

I approve

TheElixZammuto avatar May 07 '22 08:05 TheElixZammuto

I approve

exetico avatar May 07 '22 11:05 exetico

I approve

JacekJagosz avatar May 07 '22 13:05 JacekJagosz

I approve 👍

sethicis avatar May 07 '22 14:05 sethicis

I approve!

WisdomCode avatar May 07 '22 14:05 WisdomCode

I approve

hadogenes avatar May 07 '22 21:05 hadogenes

I approve.

diadatp avatar May 08 '22 05:05 diadatp

While I approve, we must also look into how this affects linking against GPL libraries and other compatibility issues we may encounter down the road; Looks like linking a GPL thing against AGPL library doesn't work, though otherwise it should be fine - So full steam ahead

@KiralyCraft where did you find that linking GPL in an AGPL project isn't allowed? I've found it to be the opposite. I am not a license/legal expert though.

  • https://www.gnu.org/licenses/license-list.en.html
  • https://opensource.stackexchange.com/a/1726
  • https://opensource.stackexchange.com/a/8436

ReenigneArcher avatar May 10 '22 18:05 ReenigneArcher

May have gotten them reversed, although I did remember there was something to keep in mind regarding GPL; Oh well, looks like it's all good then, sorry

KiralyCraft avatar May 10 '22 19:05 KiralyCraft