Sunshine
Sunshine copied to clipboard
LizardByte
Add max bitrate option
Description
Added a parameter for max bitrate to the web UI, config file and video.cpp. Additionally, made some small changes to fix CI deployment script for Windows - renamed a conflicting parameter.
Screenshot
Issues Fixed or Closed
Type of Change
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Dependency update (updates to dependencies)
- [x] Documentation update (changes to documentation)
- [ ] Repository update (changes to repository files, e.g.
.github/...)
Checklist
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added or updated the in code docstring/documentation-blocks for new or existing methods/components
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch must be updated before it can be merged. You must also Allow edits from maintainers.
- [x] I want maintainers to keep my branch updated
Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Also, there was no change to the CI. Guessing you were working off the master branch, and fixed something we already fixed in nightly?
@ReenigneArcher The PR is updated, the only thing that I didn't change was renaming the variable to DNS_REQUEST_PENDING from MY_DNS_REQUEST_PENDING. As I mentioned in the comment, doing this made my Windows build fail. Does this work for you? If so I can change it but I think renaming the variable is necessary.
@ReenigneArcher I've addressed all your comments including renaming the variable. Maybe you haven't seen it break because the action (Windows Build) only runs when pushing to the master branch. Anyway, whenever you want to make a new version, if it breaks changing the name of this variable is the fix.
It runs all all PRs, as well as push events to nightly and master branches.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
@utkarshdalal please sign the CLA if you want us to merge this. First comment in this PR has instructions. Thanks!
Anything remaining to be done on this issue?
Agreement from other team members to merge this.
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!
I mean you guys aren't reviewing it so not sure what you want from me
On Sun, 31 Mar, 2024, 14:06 LizardByte-bot, @.***> wrote:
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!
— Reply to this email directly, view it on GitHub https://github.com/LizardByte/Sunshine/pull/1463#issuecomment-2028624336, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4SWC4UXGUOAMDZHV4KMGDY27NZDAVCNFSM6AAAAAA2UO5LB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGYZDIMZTGY . You are receiving this because you were mentioned.Message ID: @.***>
@utkarshdalal I apologize, but at this time our team doesn't feel that this feature would be valuable to Sunshine. We can possibly revisit it in the future if there is more interest from users.