MapReader icon indicating copy to clipboard operation
MapReader copied to clipboard

April workshop

Open rwood-97 opened this issue 10 months ago • 4 comments

Summary

Adding notebooks for the April/May workshop.

Fixes #394

Checklist before assigning a reviewer (update as needed)

  • [x] Self-review code

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • [ ] Everything looks ok?

rwood-97 avatar Apr 23 '24 08:04 rwood-97

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.12%. Comparing base (f256ae9) to head (08fab3a).

:exclamation: Current head 08fab3a differs from pull request most recent head 7f9cb6f. Consider uploading reports for the commit 7f9cb6f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   62.39%   62.12%   -0.27%     
==========================================
  Files          39       39              
  Lines        6701     6701              
==========================================
- Hits         4181     4163      -18     
- Misses       2520     2538      +18     
Flag Coverage Δ
unittests 62.12% <ø> (-0.27%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 23 '24 08:04 codecov-commenter

Might be worth adding a line at the top of the part1 notebook to remind people to select the Python (mr_py) kernel. (Seems obvious, but I forgot first time.)

thobson88 avatar Apr 23 '24 09:04 thobson88

  • Add show context into annotation part

rwood-97 avatar Apr 24 '24 09:04 rwood-97

(Also I only reviewed part1 notebook tonight - I'll do the part2 tomorrow!)

kmcdono2 avatar Apr 29 '24 23:04 kmcdono2