MapReader
MapReader copied to clipboard
Update code to fix warnings in tests
Summary
Fixes #385
Describe your changes
Update code and dependencies to ensure fix warnings in tests
To do:
- [ ] Update docs re. how to run tests
- [ ] Deal with annotator
- [ ] Zero division error ?
Checklist before assigning a reviewer (update as needed)
- [ ] Self-review code
- [ ] Ensure submission passes current tests
- [ ] Add tests
- [ ] Update relevant docs
Reviewer checklist
Please add anything you want reviewers to specifically focus/comment on.
- [ ] Everything looks ok?
Codecov Report
Attention: Patch coverage is 78.37838%
with 16 lines
in your changes are missing coverage. Please review.
Project coverage is 62.48%. Comparing base (
fe370ee
) to head (863178d
).
Files | Patch % | Lines |
---|---|---|
mapreader/annotate/annotator.py | 40.74% | 16 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 62.47% 62.48% +0.01%
==========================================
Files 39 39
Lines 6768 6771 +3
==========================================
+ Hits 4228 4231 +3
Misses 2540 2540
Flag | Coverage Δ | |
---|---|---|
unittests | 62.48% <78.37%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Towards https://github.com/openjournals/joss-reviews/issues/6434
- [x] Check this works in 3.9 and 3.12 with worked examples notebooks !!! Then merge