android icon indicating copy to clipboard operation
android copied to clipboard

Pop out redirects

Open KentoNishi opened this issue 4 years ago • 5 comments

Some buttons in the chat and player link to external URLs. Currently, the webview redirects to the selected page. Links should open in a new browser window instead.

KentoNishi avatar Aug 11 '21 17:08 KentoNishi

Did the old app do stuff like this? WebView itself doesn't really have a concept of windows or tabs.

arkon avatar Aug 11 '21 21:08 arkon

The old app prevents navigation to other sites and opens all links in whatever browser the user has as default

KentoNishi avatar Aug 11 '21 21:08 KentoNishi

I assume it was using this code? I don't know when the extension was calling it though.

arkon avatar Aug 14 '21 16:08 arkon

oh yea i think i had a recursive self-replicating snippet that injected itself into every frame and replaced links with that function lmao

KentoNishi avatar Aug 14 '21 16:08 KentoNishi

is there any way to intercept url changes? if it's a url outside of the android asset baseurl, u can just open it up in a new browser window

KentoNishi avatar Aug 14 '21 16:08 KentoNishi

No longer relevant since not trying to use the extension anymore.

arkon avatar May 18 '24 22:05 arkon