livesplit-core icon indicating copy to clipboard operation
livesplit-core copied to clipboard

Use a dropdown instead of a text input for overriding comparisons in the component settings

Open wooferzfg opened this issue 4 years ago • 2 comments

Similar to overriding the timing method, we should show a dropdown that includes the names of all the available comparisons.

We should also decide how to handle the case where a comparison override doesn't match a comparison that's available in the current run. In the original LS, we handled this by disabling the comparison override in this case. However, we still showed the comparison override in the dropdown so that the user wouldn't accidentally disable it in the settings just by visiting the settings.

wooferzfg avatar Mar 01 '20 16:03 wooferzfg

I believe so far the idea was to simply indicate that it's a comparison from livesplit-core's side, but still keep it as essentially a textbox, and then simply populate the combobox values in the frontend.

CryZe avatar Mar 03 '20 12:03 CryZe

I think that's fine as long as the front end can tell apart a comparison setting value from a text setting value and there's an easy way to get a list of all the comparisons for the current run.

wooferzfg avatar Mar 03 '20 15:03 wooferzfg