Use slash instead of dot to separate namespace
Issue: https://github.com/LiveRamp/reslang/issues/126
Use / instead of . to separate the namespace from the rest of the topic name.
Open questions:
- Does
/count as a valid topic name in terraform?- Yes.
~ name = "rldb-customer-creation" -> "a/b/rldb-customer-creation" # forces replacement
EDIT: terraform plan doesn't complain about the DOT (.) separators either.
~ name = "rldb-customer-creation" -> "a.b/rldb-customer-creation" # forces replacement
Maybe the above line does not guarantee that SLASH (/) is valid.
- Was there a reason to transform a namespace from
name/spaceintoname-spacein the previous code?- Seems like the answer is "no". It's just how the
kebabCase/snakeCasefunction worked.
- Seems like the answer is "no". It's just how the
- Is this rename going to mess up anyone who already generated topic names?
- Could be. It recreates topics when it renames them.
- How do I bump reslang version?
- https://github.com/LiveRamp/reslang/pull/128#issuecomment-702401730
Just a drive-by, haven't considered your other questions!
This is where you update the Reslang version: https://github.com/LiveRamp/reslang/blob/master/src/main.ts#L21
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities (and
0 Security Hotspots to review)
0 Code Smells
No Coverage information
0.0% Duplication
Since this introduces a breaking change, it might be best not to merge this until we can get more fixes into the current major version. This puts us in a really tough spot.