reslang icon indicating copy to clipboard operation
reslang copied to clipboard

Use slash instead of dot to separate namespace

Open cjea opened this issue 5 years ago • 4 comments

Issue: https://github.com/LiveRamp/reslang/issues/126

Use / instead of . to separate the namespace from the rest of the topic name.

Open questions:

  • Does / count as a valid topic name in terraform?
    • Yes.
~ name  = "rldb-customer-creation" -> "a/b/rldb-customer-creation" # forces replacement

EDIT: terraform plan doesn't complain about the DOT (.) separators either.

~ name  = "rldb-customer-creation" -> "a.b/rldb-customer-creation" # forces replacement

Maybe the above line does not guarantee that SLASH (/) is valid.

  • Was there a reason to transform a namespace from name/space into name-space in the previous code?
    • Seems like the answer is "no". It's just how the kebabCase/snakeCase function worked.
  • Is this rename going to mess up anyone who already generated topic names?
    • Could be. It recreates topics when it renames them.
  • How do I bump reslang version?
    • https://github.com/LiveRamp/reslang/pull/128#issuecomment-702401730

cjea avatar Oct 01 '20 20:10 cjea

Just a drive-by, haven't considered your other questions!

This is where you update the Reslang version: https://github.com/LiveRamp/reslang/blob/master/src/main.ts#L21

njaczko avatar Oct 01 '20 21:10 njaczko

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 02 '20 16:10 sonarqubecloud[bot]

Since this introduces a breaking change, it might be best not to merge this until we can get more fixes into the current major version. This puts us in a really tough spot.

cjea avatar Oct 02 '20 16:10 cjea

This change is Reviewable

ops-github-DU4JOAWE avatar Oct 23 '20 19:10 ops-github-DU4JOAWE