Liturgist

Results 37 comments of Liturgist

@vexx32, does a formal Feature Request/Idea issue need to be created, or can this be it?

There is a string for "JsonSchemaFileOpenFailure." I need to have one for "JsonFileOpenFailure," but I do not know where/how it is created. Building now results in: `CS0117: 'TestJsonCmdletStrings' does not...

Thanks for your help and encouragement. Some progress made. Parameters created and string added. I moved from VS Code to Visual Studio. Much easier to edit the .resx strings.

I have made some changes and would like to run the Pester tests before changing it. After the current Pester tests succeed, I will add tests for the new -JsonFile...

In .\PowerShell\test\powershell\Modules\Microsoft.PowerShell.Utility\Test-Json.Tests.ps1 there are four (4) JSON strings for testing. ``` $validJson = @" $invalidTypeInJson = @" $invalidTypeInJson2 = @" $invalidNodeInJson = @" ``` To replicate these tests for the...

The only concern at this time is how the JSON file is read. I followed your advice about using SessionState to get the path. But, I am concerned that ReadAllText()...

System.IO.File.ReadAllText() will interpret files with a BOM as the correct encoding. If the coding is outside of ascii, then I am not sure how it will be interpreted. It might...

I am using `Context.SessionState.Path.GetUnresolvedProviderPathFromPSPath(JsonFile)` to resolve the file path. I am not planning to add a -Encoding parameter. Let's see if it is actually needed. Yes, it would be good...

@vexx32 - Draft PR is created. I already see some things that should change. I will be learning a lot in this process.

=== Codacy/PR Quality Review 16 identical issues in the Pester tests - test/powershell/Modules/Microsoft.PowerShell.Utility/Test-Json.Tests.ps1 ``` "Cmdlet 'Test-Json' may be used incorrectly. Please check that all mandatory parameters are supplied." ``` There...