kmongo icon indicating copy to clipboard operation
kmongo copied to clipboard

feat: added serialization for kotlinx.datetime

Open rkreienbuehl opened this issue 3 years ago • 2 comments

added serialization for kotlinx.datetime Instant, LocalDate, LocalDateTime and LocalTime

Fixes #323

rkreienbuehl avatar Sep 20 '22 11:09 rkreienbuehl

Codecov Report

Base: 58.17% // Head: 58.43% // Increases project coverage by +0.26% :tada:

Coverage data is based on head (bf72b5f) compared to base (72a0d04). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #373      +/-   ##
============================================
+ Coverage     58.17%   58.43%   +0.26%     
- Complexity      752      753       +1     
============================================
  Files           135      135              
  Lines          5604     5640      +36     
  Branches        477      477              
============================================
+ Hits           3260     3296      +36     
- Misses         2132     2133       +1     
+ Partials        212      211       -1     
Impacted Files Coverage Δ
...ain/kotlin/org/litote/kmongo/jackson/BsonModule.kt 64.77% <100.00%> (+2.93%) :arrow_up:
...in/org/litote/kmongo/jackson/ExtendedJsonModule.kt 81.81% <100.00%> (+2.59%) :arrow_up:
...n/kotlin/org/litote/kmongo/jackson/JacksonCodec.kt 57.57% <100.00%> (+2.73%) :arrow_up:
...litote/kmongo/coroutine/CoroutineClientSessions.kt 50.00% <0.00%> (-25.00%) :arrow_down:
...org/bson/codecs/pojo/PropertyReflectionUtils2.java 83.78% <0.00%> (+2.70%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 20 '22 11:09 codecov[bot]

Thanks for your response. I will implement this and update the pull request.

rkreienbuehl avatar Sep 21 '22 05:09 rkreienbuehl

Sorry for the delay. I had much to do. At first I forgot to implement jackson serialization. I now added jackson serialization and added tests.

rkreienbuehl avatar Oct 11 '22 07:10 rkreienbuehl

LGTM. Thank you !

zigzago avatar Oct 28 '22 09:10 zigzago