LitoMore

Results 303 comments of LitoMore

Can you add some tests for this change?

@HariSekhon Simply append the attribute `fill="#0A66C2"` to the SVG source before the base64 encoding.

@wirrywoo The `sktime.svg` needs some optimizations. Even the official resource has less control points than yours. Can you take a look? |Yours|Offical| |:-:|:-:| |![](https://github.com/user-attachments/assets/e8e765d2-247e-48f2-a1f0-25906e1dcf76)|![](https://github.com/user-attachments/assets/972b627c-d122-4a60-8c10-ff7efe77fbbe)|

Alright, once again. Another earthquake to GitHub. Even though it all seems a bit ridiculous to me. But let's go.

@markadrake We can't. Here is [their reply](https://github.com/user-attachments/assets/2b9b719a-4f1d-4497-a38f-200cc6b306b7). We have tried. But you can try to reach out to them yourself. For related discussions, see: - https://github.com/simple-icons/simple-icons/discussions/12524

@markadrake Thanks. I just forwarded your comment to our maintainers. Let's see what they think about this.

I see. I think we can polish those error message. It's hard to understand. The actual and expected are also written in reverse.

Note there are two errors, this means the first line also errored. ```markdown - - https://cdn.simpleicons.org/simpleicons/_/eee ```

We have been attacked before with endpoint badges. Using `image-size` to calculate image sizes on our server may introduce potential security issues. Here is a security issue they had before:...

Then I think this should be fine, since the base64 image will not be too large, given the URL length limit.