web-check icon indicating copy to clipboard operation
web-check copied to clipboard

Update Dockerfile (#43)

Open Lissy93 opened this issue 2 years ago • 1 comments

Updates the Dockerfile with changes suggested by @GWnbsp in https://github.com/Lissy93/web-check/issues/43#issuecomment-1719212234

Summary of Changes

  1. ARG Statements: Introduced ARG statements for Node.js and Debian versions, making the Dockerfile more customizable.
  2. SHELL Command: Changed the default shell to Bash with certain options enabled, improving robustness.
  3. Chromium Installation: Updated Chromium installation to use Google's signing keys and repositories, aiming for more secure and up-to-date packages.
  4. Chromium Version: Added a step to save Chromium's version into /etc/chromium-version for reference.
  5. Directory Creation: Added a new directory /app/data in the container's filesystem.
  6. CMD Change: Changed the CMD to start Node.js server (server.js) instead of using yarn serve.
  7. General Cleanup and Comments: Code has been refactored for better readability and detailed comments have been added for clarity.
  8. Dependency Installation: Kept yarn install and the removal of the Yarn cache, but the command is more streamlined.
  9. Other Minor Changes: 9.1. Added flags like -qq and --no-install-recommends for quieter and optimized installation. 9.2. Enhanced cleanup with rm -rf /var/lib/apt/lists/*.

Lissy93 avatar Sep 14 '23 20:09 Lissy93

Deploy Preview for web-check ready!

Name Link
Latest commit a6711aeb63e6ea0d18c34832ea183f80c1b2271e
Latest deploy log https://app.netlify.com/sites/web-check/deploys/6503664ee1b6290008a80b7c
Deploy Preview https://deploy-preview-55--web-check.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 14 '23 20:09 netlify[bot]