dashy
dashy copied to clipboard
Lissy93
[REVERT][REVERRT] Add group and user in dockerfile to run container as unprivileged
PR to re-apply @Singebob's changes originally released in #495.
There was an issue that caused breaking changes for users, as raised in #498 and #499
Before merging, I need to either fix this, or update the documentation appropriately.
✔️ Deploy Preview for dashy-dev ready!
🔨 Explore the source changes: 39dbb4c4fcd69c993fd54ceade18b439ede9b473
🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6212c4e69a4b220008d6cd09
😎 Browse the preview: https://deploy-preview-502--dashy-dev.netlify.app
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
![viezly[bot] avatar](https://avatars.githubusercontent.com/in/100622?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR is stale because it has been open 6 weeks with no activity. Either remove the stale label or comment below with a short update, otherwise this PR will be closed in 5 days.
In my testing to run Dashy in my Kubernetes cluster, I can't get the app to run as a non-root user. There are two main issues:
- Default port is 80, which is not usable by a non-root user. Easy to fix by setting the
PORTvariable to a higher number (8080 works). - Part of the startup process does an
rmdir /app/dist. If I run the code as a non-root user, it doesn't have the permissions to do this and the startup fails. I don't have a workaround for this one.
I'm not sure the changes in this PR would fix the second issue.
This PR is stale because it has been open 6 weeks with no activity. Either remove the stale label or comment below with a short update, otherwise this PR will be closed in 5 days.