dashy
dashy copied to clipboard
Lissy93
[BUG] pageInfo.title no longer displayed in browser tab
Environment
Self-Hosted (Docker)
System
No response
Version
3.0.0
Describe the problem
After upgrading from 2.1.2 to 3.0.0 the title configured in pageInfo.title is no longer displayed in the browser tab.
As a workaround I defined the environment variable VUE_APP_TITLE which solves the issue.
I assume this is because of the recent changes to the makeMetaTags const: https://github.com/Lissy93/dashy/commit/a1bf7a69311a95487f30faa7324e270917d56dd7#diff-d7f41ba1aa74f41ef4b0c2337abe593d08092ffae6528a8aa2db712afeee0b66L69-L72
Additional info
No response
Please tick the boxes
- [X] You have explained the issue clearly, and included all relevant info
- [X] You are using a supported version of Dashy
- [X] You've checked that this issue hasn't already been raised
- [X] You've checked the docs and troubleshooting guide
- [X] You agree to the code of conduct
I assume this is because of the recent changes to the makeMetaTags const:
a1bf7a6
You are correct. Since the config is now loaded at runtime, yet page title needs to go into the Vue router, which needs to be compiled, it was no longer possible to load that dynamically.
I've pushed an update (not merged yet), which will set the title (client-side) to whatever is in pageInfo.title. It will go live once #1542 is merged.
I was about to post an issue about this haha thanks for this update, much appreciated
