dashy
dashy copied to clipboard
Move config.yml to config subdirectory
Allows to use a folder as docker volume (eg. NFS share). Addresses https://github.com/Lissy93/dashy/issues/1322
Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)
Category:
Feature
Overview
Moves the conf.yml into a new subdirectory
config, so that this whole folder can be bind mounted into the docker container. That way we can have a docker volume from NFS (or similar).
Issue Number (if applicable) #1322
New Vars (if applicable)
If you've added any new build scripts, environmental variables, config file options, dependency or devDependency, please outline here
Screenshot (if applicable)
If you've introduced any significant UI changes, please include a screenshot
Code Quality Checklist (Please complete)
- [x] All changes are backwards compatible
- [x] All lint checks and tests are passing
- [x] There are no (new) build warnings or errors
- [x] (If a new config option is added) Attribute is outlined in the schema and documented
- [x] (If a new dependency is added) Package is essential, and has been checked out for security or performance
- [x] Bumps version, if new feature added
Deploy Preview for dashy-dev ready!
| Name | Link |
|---|---|
| Latest commit | 802823ba030f4371e8e163ab74599fab364e39c8 |
| Latest deploy log | https://app.netlify.com/sites/dashy-dev/deploys/655a09f17cd942000822d48a |
| Deploy Preview | https://deploy-preview-1393--dashy-dev.netlify.app/ |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| dashy | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 19, 2023 1:14pm |
Might also address a subset of #693
Hi Thank you for your Contribution, take a look at Dashy V3 https://github.com/Lissy93/dashy/discussions/1537 and https://github.com/Lissy93/dashy/discussions/1529 which already includes the contents of your PR.
Cheers @bajo and @joshbuker - sorry this took so long to come around to. Given it was a breaking change it made sense to include it with the other breaking changes (for no app rebuilding) and do a major version bump, which took me longer than expected to get finished.
Cheers @bajo and @joshbuker - sorry this took so long to come around to. Given it was a breaking change it made sense to include it with the other breaking changes (for no app rebuilding) and do a major version bump, which took me longer than expected to get finished.
All good! Really appreciate your work!
Cheers @bajo and @joshbuker - sorry this took so long to come around to. Given it was a breaking change it made sense to include it with the other breaking changes (for no app rebuilding) and do a major version bump, which took me longer than expected to get finished.
Thanks a lot @Lissy93 . Glad it made it into the release. :)
