dashy icon indicating copy to clipboard operation
dashy copied to clipboard

Add support searching multiple words.

Open ssrangisetti opened this issue 2 years ago • 2 comments

ssrangisetti Quick ssrangisetti /patch-1 → Lissy93/dashy Commits: 2 | Files Changed: 1 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

Category: Feature improvement

Overview When search field has multiple words like quick fox or dog fox in string like The quick brown fox jumps over the lazy dog it would be helpful to search for each word in the sentence instead of considering entire search string as single word. If a user gives multiple space separated tags, this ensures that items which contain all the search tags are returned

Ex 1: compareStr: The quick brown fox jumps over the lazy dog, searchStr: dog fox, previous result: false, now: true Ex 2: compareStr: ['abcd', 'xyz', 'pqr'], searchStr: abcd xyz, previous result: false, now: true

Code Quality Checklist (Please complete)

  • [ ] All changes are backwards compatible (not backwards compatible because search behaviour changed)
  • [x] All lint checks and tests are passing
  • [x] There are no (new) build warnings or errors
  • [ ] (If a new config option is added) Attribute is outlined in the schema and documented
  • [ ] (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • [ ] Bumps version, if new feature added

ssrangisetti avatar May 03 '23 17:05 ssrangisetti

Deploy Preview for dashy-dev ready!

Name Link
Latest commit 3f3ffac63b3c54b60006612ab317f5ff84fe47a1
Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/6452a71191fc4d0008650ea8
Deploy Preview https://deploy-preview-1171--dashy-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 03 '23 17:05 netlify[bot]

Changes preview:

Legend:

👀 Review pull request on Viezly

viezly[bot] avatar May 03 '23 17:05 viezly[bot]