human_curl icon indicating copy to clipboard operation
human_curl copied to clipboard

requests compatibility issues

Open pythonmobile opened this issue 13 years ago • 5 comments

Seems like most of the API of requests does not work in human_curl

For instance:

import human_curl as requests r = requests.get("https://..." , verify=False) -- rename validate_cert to verify? requests.get("https://..." , verify=False).text -- rename content to text?

pythonmobile avatar Aug 06 '12 17:08 pythonmobile

I don't watch requests development some of requests features appear early in human_curl. SSL CERT VERIFICATION too. I will think about it.

Lispython avatar Aug 06 '12 17:08 Lispython

Another issue is that requests accepts unicode urls. We should try to support that in human_curl as well?

pythonmobile avatar Aug 06 '12 17:08 pythonmobile

After some time, I change my opinion and think that human_curl need more compitibility with requests.

Lispython avatar Mar 02 '13 06:03 Lispython

+1

honzajavorek avatar Sep 16 '13 09:09 honzajavorek

After a couple of tests the most obvious compatibility issues are

  • the unicode support
  • post content type (right now it defaults to multipart)
  • certificate verification flag naming

Honestly, I would start a discussion with the requests community in order to provide support for pycurl. This way we can have clear API specs and focus on adapters integration. Not to mention the benefits it would have for requests package (improved speed and socks proxy support are worth mentioning).

/cc @kennethreitz

stas avatar Oct 09 '14 10:10 stas