lisk-sdk icon indicating copy to clipboard operation
lisk-sdk copied to clipboard

Incorrect naming `const allKeys = ....`

Open sitetester opened this issue 3 years ago • 0 comments

Description

const allKeys = [...params.mandatoryKeys, ...params.optionalKeys].map((key, index) => ({
	key,
	signature: params.signatures[index],
}));

Here allKeys should be renamed to signaturesByKey

Motivation

Since it contains combination of signature & key & not just all keys.

Additional Information

framework/src/modules/auth/commands/register_multisignature.ts

sitetester avatar Aug 24 '22 08:08 sitetester