lisk-mobile
lisk-mobile copied to clipboard
Changes to WalletConnect package files/folders naming
Description
There are some naming improvements we would like to do on the recently implemented wallet-connect package on Desktop (PR here).
Proposal
- Make the wallet-connect code to live in
./packages/wallet-connect/...
instead of./libs/...
. This could be a React cross-client package that eventually in a future will be a Lisk could be published on npm. - Change to PascalCase the
libs/wcm/context/...
, since they are React components. - Make
ConnectionSummary
a react hook (useConnectionSummary
), since no UI is rendered, only hooks. - Provide a clear
error
,isLoading
andisSuccess
API on hooks for all external connection actions, including set a connection, disconnect application, loading connection, etc. We are having to make this state transition states on each component, and would be nice to have it centralised in one place. - Make separate hooks for approving, rejecting and responding to session requests (split in multiple hooks the
useSession
actual hook). Adderror
,isLoading
andisSuccess
for each one.