Lipu Fei

Results 18 comments of Lipu Fei

We are still using the MKL versions on Windows. I will create some builds with this change so we can test it.

Hi @thopiekar , this PR fails to build Cura on Windows. I got the following error messages: ``` [ 97%] Completed 'fdm_materials' [ 97%] Built target fdm_materials Scanning dependencies of...

Well, apparently if you don't do that it won't work...

> @LipuFei can you add tests for when this executor is set? Following LocalExecutor is probably a reasonable way to find place where cases should be added. @jedcunningham I didn't...

Hi @eladkal @o-nikolas @jedcunningham , I have updated my changes and the PR description. Could you check it again? Thanks.

> Thanks @LipuFei. Can you add tests for this also? Might be worth running around looking at LocalExecutor cases, as that's the most similar from the charts perspective I think....

I've updated this PR. All checks have passed. From my point of view, this PR is ready for merge 😄 if there's no further comments...