Lior Lieberman
Lior Lieberman
/uncc @aojea /uncc @mrbobbytables /cc @johnbelamaric
@johnbelamaric can you take a look?
> > folks, these are not user stories, these are developer stories to solve some user stories (that are not specified), I'd like to read the problems we are solving...
I am going to add tomorrow to the KEP the relevant change I am proposing to the godoc in the two places AppProtocol is in which is [ServicePort](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/types.go#L4080-L4087) and [EndpointPort](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/discovery/types.go#L162-L169)....
/test pull-enhancements-verify
/test pull-enhancements-verify
@robscott @howardjohn @aojea @danwinship PTAL I have made some changes and added followup work
/test pull-enhancements-verify
Yes, I have not looked at the KEP you have opened https://github.com/kubernetes/enhancements/pull/3787 but presumably we will see if we should move values from here to the new Names DB in...
Thanks @thockin, I have addressed all your feedback - regarding the two last bullets in the checklist; I need to change the documentation - https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol should we merge this first...