In emacs-macport, only switches to dark theme when Dark Mode is toggled

[what-the-functor]

trafficstars

If emacs-macport is launched when Dark Mode is active, the theme is not switched to the dark theme. However, if I toggle Dark Mode (off, then on) the theme is switched.

The emacs-macport hook mac-effective-appearance-change-hook is set to auto-dark--check-and-set-dark-mode. This is working very well, though only when Dark Mode is actively toggled.

The aforementioned hook is not invoked when emacs starts, so there should be a mechanism at startup to check and set the dark mode. In my configuration, I've solved this by adding auto-dark--check-and-set-dark-mode to emacs-startup-hook, though there is a flash of the light theme. I think that the flash of light can be avoided by utilising before-make-frame-hook in early-init.el.

[sellout]

I‘m curious whether #74 fixes this for you.

I’m also curious (regardless of whether you test #74) what your configuration looks like. E.g.,

(use-package auto-dark
  :custom (auto-dark-dark-theme 'meh-dark)
  :init (auto-dark-mode))

or

(auto-dark-mode 1)

(custom-set-variables
 '(auto-dark-dark-theme 'meh-dark))

or

(custom-set-variables
 '(auto-dark-dark-theme 'meh-dark))

(auto-dark-mode 1)

or something else.

[LionyxML]

@what-the-functor, I've been working through some PRs that had been sitting in my "sorry, no time right now" drawer. Could you please check if this bug report is still valid?

[what-the-functor]

@LionyxML, yes I will check. It may take 1-2 days.