monitoring-plugins icon indicating copy to clipboard operation
monitoring-plugins copied to clipboard

Build Error: Cannot package the path '/tmp/dist/summary/check-plugins/The Unlicense

Open Domi-cc opened this issue 1 year ago • 2 comments

This issue respects the following points:

  • [X] This is a bug, not a question or a setup/configuration issue.
  • [X] This issue is not already reported on Github (I've searched it).
  • [X] I use the latest release of the Monitoring Plugins (https://github.com/Linuxfabrik/monitoring-plugins/releases).
  • [X] I agree to follow Monitoring Plugins's Code of Conduct.

Which variant of the Monitoring Plugins do you use?

  • [ ] .rpm/.deb package from repo.linuxfabrik.ch
  • [ ] Compiled for Linux (.tar/.zip from download.linuxfabrik.ch)
  • [ ] Compiled for Windows (from download.linuxfabrik.ch)
  • [X] Source Code from GitHub

Bug description

i got an error while building the Plugins with the included buildscripts:

{:timestamp=>"2023-12-29T11:46:57.120435+0000", :message=>"Invalid package configuration: Cannot package the path '/tmp/dist/summary/check-plugins/The Unlicense', does it exist?", :level=>:error}

I used a debian12 docker container to build the packages:

  docker run \
  --rm \
  --pull always \
  --mount type=bind,source="/dockerdata/linuxfabrik_plugin_builder/repo-linuxfabrik-monitoring-plugins",target=/repos/monitoring-plugins,readonly \
  --mount type=bind,source="/mnt/shareall/linuxfabrik-monitoring-plugins/tmp",target=/build \
  debian:12 \
  bash /repos/monitoring-plugins/build/debian12/build.sh

the first mount is the git repo from master, the second mount is only to output the packages from the container.

Steps to reproduce - Plugin call

--

Steps to reproduce - Data

No response

Environment

debian12 docker container

Plugin Version

--

Python version

No response

List of Python modules

No response

Additional Information

No response

Domi-cc avatar Dec 29 '23 11:12 Domi-cc

it seems, the problem occurs, because PACKAGE_VERSION and PACKAGE_ITERATION is not set.

So it would be great, to have default values there or change the script to raise an error if parameters are not set.

Domi-cc avatar Dec 29 '23 12:12 Domi-cc

next trap: please also add to the script a check, if the lib folder is there ;)

Domi-cc avatar Dec 29 '23 13:12 Domi-cc