FHIR icon indicating copy to clipboard operation
FHIR copied to clipboard

SUBSETTED tag should be on the individual resources, not on the wrapping bundle

Open lmsurpre opened this issue 3 years ago • 1 comments

Describe the bug When clients perform a search request with _summary or _elements parameteters, we mark the response with a SUBSETTED tag:

{
	"resourceType": "Bundle",
	"id": "11e8bf11-6790-44c6-af1e-1d765af70126",
	"meta": {
		"tag": [
			{
				"system": "http://terminology.hl7.org/CodeSystem/v3-ObservationValue",
				"code": "SUBSETTED",
				"display": "subsetted"
			}
		]
	},

Based on https://chat.fhir.org/#narrow/stream/179166-implementers/topic/Adding.20subsetted.20tag.20for.20_summary/near/214114494 the specification intended us to mark the individual resources instead, because "it's not the bundle that is being summarized"

UPDATE: it turns out that we do mark the resources themselves as subsetted. The only question is whether we should remove the tag from the wrapper bundle. This is not a bug.

Environment main

To Reproduce Steps to reproduce the behavior:

  1. perform a search with _summary=true
  2. check the results

Expected behavior Each resource in the result should have a coding with value SUBSETTED

Additional context There is also ongoing discussion about whether this should be at Resource.meta.tag or Resource.meta.security: https://chat.fhir.org/#narrow/stream/179247-Security-and-Privacy/topic/summary.20-.3E.20Subsetted/near/282637503

We should align our implementation with the results of that conversation. See https://jira.hl7.org/browse/FHIR-20698

lmsurpre avatar May 17 '22 14:05 lmsurpre

Lets go ahead and remove that tag from the outer bundle.

lmsurpre avatar Sep 20 '22 13:09 lmsurpre