fix for W215_v2 FW1.24

Open tnstar opened this issue 8 years ago • 4 comments

W215_A2 have different device id mapping than the default, so this fixes the W215_V2 issue. However, this is still not smart enough to detect the model number and automatically apply the fix. We need to set use_legacy_protocol to True during SmartPlug init.

Jun 18 '17 07:06 tnstar

Thanks for the PR!

Your work looks solid but it is really difficult to review a Christmas tree commit. I am guessing you use some auto pep8 plug-in? Would you mind turning it of and resubmit it as two commits (One with the core changes and one with style changes).

I have no problem with pep8 commits as it makes the code more readable but it becomes very difficult to see style and function if everything is in a single commit.

Then I will be happy to merge your improvements.

Jun 19 '17 10:06 LinuxChristian

I agree, it would be great to get a pep8 change and then a separate change for W215_v2 FW1.24. I'd recommend two different pull requests.

Jun 22 '17 04:06 clach04

Ok, I will do pep8 first and then the fix.

Jun 22 '17 04:06 tnstar

bump... Commit #25 does the same?

Dec 12 '17 19:12 LinuxChristian