node-loudness icon indicating copy to clipboard operation
node-loudness copied to clipboard

Better linux support

Open elderapo opened this issue 8 years ago • 2 comments

This pull request fixes:

  • [x] Muting/unmuting (#4).
  • [x] setVolume previously wasn't working as intended for example: setVolume(15, cb) was setting volume to 16 instead of 15 but setVolume(50, cb) was correctly setting volume to 50. Now it works for all the values 0-100%.

Since only @RyanAfrish7 (Ubuntu 16.04 LTS) and I (Ubuntu 14.04 LTS) reported problems fixed in this pull request I assume these errors only appeared on various Ubuntu distributions.

elderapo avatar Sep 10 '17 16:09 elderapo

Oh.. I just realized I made a mess by including pull request with windows support as well. Will try to fix it asap.

elderapo avatar Sep 10 '17 16:09 elderapo

I did my best to clear the mess I made. If it's still not acceptable let me know and I will just open a new "clear" pull request.

elderapo avatar Sep 10 '17 17:09 elderapo