flutter_web_auth icon indicating copy to clipboard operation
flutter_web_auth copied to clipboard

iOS Authentication works in 0.4.0, but not in 0.4.1 - AQUIRE_ROOT_VIEW_CONTROLLER_FAILED

Open Will5 opened this issue 3 years ago • 4 comments

As per discussion in 135, I created a pull request. I tested in a Flutter application, but not in an "add to app" use case.

Will5 avatar Nov 17 '22 21:11 Will5

@Will5 I have pushed your changes into a separate branch in flutter_web_auth_2. It would be very nice if you could test them on your device(s) to see if they fix your issue: https://github.com/ThexXTURBOXx/flutter_web_auth_2/tree/fix-135 You can use the branch by using the following entry in your pubspec.yaml:

  flutter_web_auth_2:
    git:
      url: https://github.com/ThexXTURBOXx/flutter_web_auth_2.git
      ref: fix-135

ThexXTURBOXx avatar Dec 13 '22 11:12 ThexXTURBOXx

@Will5 Sorry for pinging you again, I just wanted to ask you if you had a chance to try my branch out. Then, I could publish the fix for everyone to profit :)

ThexXTURBOXx avatar Dec 22 '22 08:12 ThexXTURBOXx

@ThexXTURBOXx, odd. When I use your branch, I get the AQUIRE_ROOT_VIEW_CONTROLLER_FAILED error, but when I use my branch, I don't. I'm trying to figure out what's different.

flutter_web_auth_2:
  git:
    url: https://github.com/ThexXTURBOXx/flutter_web_auth_2.git
    ref: fix-135
    path: flutter_web_auth_2
flutter_web_auth:
  git:
    url: https://github.com/Will5/flutter_web_auth.git
    ref: AQUIRE_ROOT_VIEW_CONTROLLER_FAILED

EDIT: @ThexXTURBOXx, never mind. I was also able to get it to work, but there appears to be some sort of race condition. I went back to your branch, and if I clicked on the button quickly, I got the error, but if I waited a little bit and clicked on the button, I didn't. I'll see if I can figure that out what could be causing it.

Will5 avatar Dec 30 '22 16:12 Will5

@Will5 Thanks for reporting back! Okay, let me know when you find a solution and I will merge it asap :)

ThexXTURBOXx avatar Dec 30 '22 17:12 ThexXTURBOXx