flutter_web_auth icon indicating copy to clipboard operation
flutter_web_auth copied to clipboard

update to flutter 3 and fix lint warnings

Open noga-dev opened this issue 2 years ago • 15 comments

Addresses #117

noga-dev avatar May 12 '22 15:05 noga-dev

I would appreciate this getting merged and published

Perondas avatar May 18 '22 09:05 Perondas

@LinusU We have some important stuff to fix here again :)

Btw: Until this is merged, you can use this fork by declaring a dependency_override:

dependency_overrides:
  flutter_web_auth:
    git:
      url: https://github.com/noga-dev/flutter_web_auth.git

ThexXTURBOXx avatar May 18 '22 21:05 ThexXTURBOXx

When this will be merged?

niteshsh4rma avatar May 30 '22 07:05 niteshsh4rma

You should constrain to flutter>=3.0.0 in pubspec.yaml. Like this:

environment:
  sdk: ">=2.12.0 <3.0.0"
  flutter: ">=3.0.0"

Just to make sure, no one uses the newest version of this package with older flutter sdk's.

igoriuz avatar Jun 13 '22 17:06 igoriuz

Wake up, it's time to merge. My debug console is burning out. 🥱

p4-k4 avatar Jun 20 '22 08:06 p4-k4

I contacted @LinusU via email whether I could help him managing incoming PRs and so on for this package, but sadly did not receive a reponse to that yet. Let's just wait a bit more and maybe at some point, this will get published. For the time being, use this: https://github.com/LinusU/flutter_web_auth/pull/118#issuecomment-1130567768

ThexXTURBOXx avatar Jun 20 '22 08:06 ThexXTURBOXx

@LinusU kind reminder to merge this please

jaumard avatar Jun 30 '22 12:06 jaumard

@LinusU can you check this PR, please? The community likes and is helping this project!

tulioccalazans avatar Aug 08 '22 12:08 tulioccalazans

@LinusU sorry to disturb you one more time. Got an idea...since this is a quite popular package, and also a dependency of appwrite (another popular package), it would be great for the community to keep it up to date. If you like, we could maintain it over at https://github.com/fluttercommunity. Or you could make @ThexXTURBOXx a collaborator. What do you think? 🤗

nohli avatar Aug 09 '22 11:08 nohli

@nohli Yes, fluttercommunity would be a great idea! I would also still offer my help in helping maintaining this package :)

ThexXTURBOXx avatar Aug 09 '22 12:08 ThexXTURBOXx

@peterhijma please approve this and merge ASAP, its already too much time since this issue is opened.

niteshsh4rma avatar Aug 10 '22 06:08 niteshsh4rma

I thought about forking this repo and publishing my own fork to pub.dev. If @LinusU does not reply until Monday, I will be publishing my own version then - of course under compliance with the MIT license. I will keep you updated here!

P.S.: If anyone is interested in becoming a co-author, please let me know so that I can add you to my fork as well then :)

ThexXTURBOXx avatar Aug 10 '22 07:08 ThexXTURBOXx

I thought about forking this repo and publishing my own fork to pub.dev. If @LinusU does not reply until Monday, I will be publishing my own version then - of course under compliance with the MIT license. I will keep you updated here!

P.S.: If anyone is interested in becoming a co-author, please let me know so that I can add you to my fork as well then :)

Thanks @ThexXTURBOXx , also I'll like to co-author this project.

niteshsh4rma avatar Aug 10 '22 07:08 niteshsh4rma

@niteshsh4rma As soon as I have everything set up, I will let you know! Thanks for volunteering :)

ThexXTURBOXx avatar Aug 10 '22 07:08 ThexXTURBOXx

For follow-ups, see here: https://pub.dev/packages/flutter_web_auth_2

ThexXTURBOXx avatar Aug 20 '22 15:08 ThexXTURBOXx

This was addressed in another PR, and is now released in 🚢 0.4.2 / 2022-11-01

Thanks for the PR 🙏

LinusU avatar Nov 01 '22 10:11 LinusU

This had do be reverted since it broke Flutter v2 compatibility, it's now released as 🚢 0.5.0 / 2022-11-02 instead!

LinusU avatar Nov 02 '22 16:11 LinusU