flutter_web_auth
flutter_web_auth copied to clipboard
LinusU
Flutter 3 changes
Flutters API for widget binding changed and we need probably a small update to prevent a failed build. Should probably be the same error for all platforms.
Same error. The ? should be removed from WidgetBinding.instance. Since Flutter 3.0 it can't be null anymore.
You can override the pubspec to this for now:
dependency_overrides:
flutter_web_auth:
git:
url: https://github.com/noga-dev/flutter_web_auth.git
ref: ee3c26a530a625c3cab7e0c45cc30316c8b4b64c
Actually, I see this package has now been superseded by flutter_web_auth2 which doesn't have that problem, so please ignore my request.
This is now fixed in 🚢 0.4.2 / 2022-11-01
Hi Linus! It's good to know you're alive.
With that in mind:
The PR you've accepted jut now (#132) is a dupe opened over a month after #118 and lacks some extras from it.
And as I've already migrated to @ThexXTURBOXx 's fork, I would prefer to stick with it (unless he'll stop maintaining it) as he's been doing a fantastic job that deserves acknowledgement. Would you be open to letting him take over (or making him a contributor)?
Cheers and welcome back.
Thanks!
Yes, that was intentional since I didn't want to force Flutter 3.0 in a minor version. Other than the changed flutter version range.
I think that you can absolutely stick with the fork if that works for you 👍
This had do be reverted since it broke Flutter v2 compatibility, it's now released as 🚢 0.5.0 / 2022-11-02 instead!
This had do be reverted since it broke Flutter v2 compatibility, it's now released as 🚢 0.5.0 / 2022-11-02 instead!
Among the extras in #118 was the version constraint.
@noga-dev, yes. I didn't realise that removing the ? wasn't a backwards compatible change. Instead, I though that the version constraint wasn't needed, and that adding it would have made it a breaking change.
Sorry for not merging your PR, had I understood that it was indeed a breaking change I would absolutely have done that...
@noga-dev, yes. I didn't realise that removing the
?wasn't a backwards compatible change. Instead, I though that the version constraint wasn't needed, and that adding it would have made it a breaking change.Sorry for not merging your PR, had I understood that it was indeed a breaking change I would absolutely have done that...
Definitely an easy thing to miss. Thank you for the amazing work with the package. 🙏