csgoverview icon indicating copy to clipboard operation
csgoverview copied to clipboard

Published 20 hours ago • verified publisher icon Linus4

Unify config

Open sparkoo opened this issue 3 years ago • 4 comments

This patch removes mandatory registry key on Windows. It now does not fail, but rather uses font in repo and overviews folder as default parameters. IMHO with this it would be easier to dev and easier do distribute without installator on windows. It also now fails faster when font or overviews directory does not exist.

I've also added script do help download overviews to local folder.

Linux and Mac main files are equivalent, I've just removed some duplication. I've tested on Mac.

sparkoo avatar Jan 08 '22 22:01 sparkoo

Hi @sparkoo ! This is a great improvement, thanks a lot for your PR :)

Regarding the csgo-overviews repo: this is where the installer downloaded the images from before I switched to the imgur links. (NSI Script) As you can see, de_ancient was added just 3 months ago. I guess it would be better to use the images from Github because they have a URL that stays the same after an update, so it does not have to be changed in the install scripts. But using our own images means that we are independent from another project. Imo we could switch back to using this repo's images as they have been updated. What do you guys think? @augustoccesar @sparkoo

Linus4 avatar Jan 14 '22 13:01 Linus4

The zoidbergwill/csgo-overviews repo looks quite stable, so I wouldn't be worried it will dissapear and I don't see new maps coming either in following years so I think it's safe to use it. btw installer bundle overviews or does it download them on install ?

sparkoo avatar Jan 14 '22 20:01 sparkoo

Ok in that case, we'll switch back to the overviews from the repo. The installer downloads the overviews on install. So the links will have to be updated in the nsi script as well.

Linus4 avatar Jan 15 '22 16:01 Linus4

@Linus4 I think is fine to point to the repo as well. But I also can see the point about it taking maybe too long to add new maps or something like that. But I think we can also contribute to that repo in this case by opening PR with a new map when/if it happens. Not sure what is the speed for PR's to be merged there, but I believe is an overall good idea to depend on a stable repo dedicated to these images.

augustoccesar avatar Jan 18 '22 10:01 augustoccesar

Thanks again @sparkoo ! I will soon release a new version with your changes in it.

Linus4 avatar Mar 04 '23 12:03 Linus4