Linus045

Results 27 comments of Linus045

``` File "main.py", line 255, in sell logger.Info(f"Order is initialized but not ready. Continuing. | Status={st}") ``` This needs to be changed to logger.info(...)

What record are you referring to exactly?

I think at this point we should refactor this somehow. I tried to do some changes in #103 but if there are gonna be more and more notification channels later...

also the package needs to be added to the requirements.txt, otherwise people will get errors when trying to use the bot.

@nitad54448 I understand your problems with the bot, but please open a separate issue for that. The points you mentioned are unrelated to this specific Pull-Request and therefore don't belong...

Please create a new issue here to further discuss your problem: https://github.com/CyberPunkMetalHead/gateio-crypto-trading-bot-binance-announcements-new-coins/issues/new

I've created a new Draft PR to tackle this issue. The first step would be to just grab the first coin similar to @rrm1991's implementation. See here: #150 In the...

Is this PR still necessary after #76 has been merged?

Please also run 'black' to fix the CI checks (see README.md). see CI check log: ``` would reformat src/gateio_new_coins_announcements_bot/auth/gateio_auth.py would reformat src/gateio_new_coins_announcements_bot/send_telegram.py ```

I implemented a possible version of this on my own fork on the develop branch see here: https://github.com/Linus045/gateio-crypto-trading-bot-binance-announcements-new-coins/blob/develop/tests/test_new_listings_scraper.py I'm using pytest-mock and requests-mock to simulate the possible requests/unrelated function calls....