venus.js icon indicating copy to clipboard operation
venus.js copied to clipboard

Venus Forces Non-Secure Protocol on Hostname

Open derekbrown opened this issue 12 years ago • 4 comments
trafficstars

When specifying a hostname in command line via the --hostname flag, Venus automatically prepends "http://". For my purposes, I think this should only be done if the string passed to --hostname does not begin with a protocol string. As a use case, I have tests that are hosted on a secure host that I cannot run remotely.

-Derek

derekbrown avatar Oct 01 '13 18:10 derekbrown

Hey Derek, could you checkout out #292. Is this what you had in mind? Trying to fully understand your scenario.

sethmcl avatar Oct 01 '13 18:10 sethmcl

That is exactly what I had in mind for what I'm doing. I'm just trying to be a bit more forward thinking in terms of other use cases. What if the tests are on an FTP server? Or to be run over SSH? Etc. I think for sustainability, Venus should run a RegEx against the hostname string. If it begins with a protocol ("____://"), then don't add one. If it doesn't, default to http:// ?

The --secure option works perfect for me, though.

derekbrown avatar Oct 01 '13 19:10 derekbrown

Not sure why the tests would be on some other server? They are served by venus so they are on the Venus server, which is http:// by default.

sethmcl avatar Oct 01 '13 20:10 sethmcl

Yeah. In this case, I had a request where someone wants to automate tests within a Gitli-hosted repository without pulling it down. :)

derekbrown avatar Oct 01 '13 21:10 derekbrown