venus.js
venus.js copied to clipboard
LinkedInAttic
Test results not printing properly
Hey Seth,
I got the latest from master today and I noticed that the reporter was not giving me correct information. I looked a little into the code and it seems like onResults is never being called on executor.js.
It seems like it should be called when the results event is emitted in the socket:
socket.on('results', _.bind(self.onResults, self));
But I couldn't find where that event was supposed to be emitted. Can you please look into this when you have some time?
Thanks, Adrian
Hi Adrian,
Could you provide some more details on the output you are seeing? It seems to be working fine for me. I just pulled master and ran this command to test:
venus run -t examples/ -n
Output seems to be as expected.
Thanks! Seth
Hey Seth,
I just pulled the latest again and tried running the examples:
As you can see it says 0 tests executed, 0 passed and 0 failed.
Can you try running: venus run -t examples/ -n --hostname localhost to
see if that fixes it?
On Sun, Jul 14, 2013 at 6:14 PM, Adrian Ancona Novelo < [email protected]> wrote:
Hey Seth,
I just pulled the latest again and tried running the examples:
[image: venus_examples]https://f.cloud.github.com/assets/281836/795246/b41fe7a0-eceb-11e2-8dfa-726c369a170a.png
As you can see it says 0 tests executed, 0 passed and 0 failed.
— Reply to this email directly or view it on GitHubhttps://github.com/linkedin/venus.js/issues/250#issuecomment-20948155 .
Hey Seth,
I tried your suggestion but I get the same output.
Regards, Adrian
Is this on a Mac? Can you try rerunning npm install?
On Monday, July 15, 2013, Adrian Ancona Novelo wrote:
Hey Seth,
I tried your suggestion but I get the same output.
Regards, Adrian
— Reply to this email directly or view it on GitHubhttps://github.com/linkedin/venus.js/issues/250#issuecomment-21019941 .
Hey Seth,
I deleted the node_modules folder and ran npm install again but the problem persists. This is my personal Linux computer.
Regards, Adrian
Is this only with phantom? Do tests run in the browser?
On Monday, July 15, 2013, Adrian Ancona Novelo wrote:
Hey Seth,
I deleted the node_modules folder and ran npm install again but the problem persists. This is my personal Linux computer.
Regards, Adrian
— Reply to this email directly or view it on GitHubhttps://github.com/linkedin/venus.js/issues/250#issuecomment-21022744 .
Tests run correctly in the browser. It also seems like the tests run correctly in phantom but since onResults is never executed the output is incorrect.