sepia icon indicating copy to clipboard operation
sepia copied to clipboard

nodejs 6 issues

Open satazor opened this issue 8 years ago • 2 comments

I've got a project with fixtures generated using nodejs 4 but the same fixtures do not work in nodejs 6 because they have a different signature. It seems that nodejs 6 changed some internals that are causing this issue.

satazor avatar Jul 06 '16 16:07 satazor

After investigating, the issue is with JSON.stringify here: https://github.com/linkedin/sepia/blob/master/src/util.js#L339

Node 4 and Node 6 have discrepancies in the way they output unicodes.. one simply output as text and other as ASCII text (e.g.: \uxxxx).

One way to solve it is to base64 the JSON.stringify ouput before passing it to crypto.

satazor avatar Sep 26 '16 23:09 satazor

I just went from node 4.4.3 to 6.9.1 and didn't see any issues. Did they fix something in 6?

jimmyeisenhauer avatar Oct 25 '16 20:10 jimmyeisenhauer