naarad
naarad copied to clipboard
Multiple test failures
When I try running the naarad tests, I get multiple test failures. This happens when running them manually or using something like nose. Example test failure:
======================================================================
ERROR: Tests to verify that metric reports are generated if the metrics are not in error. Also a summary report should be created.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/patrick/dev/sandbox/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/Users/patrick/dev/naarad/test/test_report.py", line 121, in test_metrics_with_summary_without_error
metrics = get_three_metrics(output_directory, resource_path, rules)
File "/Users/patrick/dev/naarad/test/test_report.py", line 51, in get_three_metrics
metrics = [Metric('MetricOne', 'TestOne.csv', 'HostnameOne', output_directory, resource_path, 'MetricOne', None, None, rules, None, None),
TypeError: __init__() takes exactly 13 arguments (12 given)
This looks like a shallow enough failure, but it raises a few questions. What is the intended way to run the naarad tests? It would be nice if it were documented.
It is also easy enough to add a Travis config so that the tests are automatically run so that it's obvious when a commit breaks something.