Duplicate constants and incorrect files?

[richardhsu]

Under src/naarad/naarad_constants.py.

Any reason for duplicate proc output files? Otherwise will remove and need to fix conf files to also utilize the proc.###.out file convention.

#Auto Discover Metrics
SUPPORTED_FILENAME_MAPPING = {
  'gc.log' : 'GC',
  'perf-results.xml' : 'JMETER',
  'perf-result.xml' : 'JMETER',
  'proc.vmstat.out' : 'PROCVMSTAT', <--
  'procvmstat.out' : 'PROCVMSTAT',  <-- Not created by sar.sh anymore
  'proc.meminfo.out' : 'PROCMEMINFO', <--
  'procmeminfo.out' : 'PROCMEMINFO',  <-- Not created by sar.sh anymore
  'proc.zoneinfo.out' : 'PROCZONEINFO', <--
  'proczoneinfo.out' : 'PROCZONEINFO',  <-- Not created by sar.sh anymore
  'sar.cpuhz.out' : 'SAR-cpuhz',
  'sar.cpuusage.out' : 'SAR-cpuusage',
  'sar.device.out' : 'SAR-device',
  'sar.edev.out' : 'SAR-edev',
  'sar.etcp.out' : 'SAR-etcp',
  'sar.memory.out' : 'SAR-memory',
  'sar.memutil.out' : 'SAR-memutil',
  'sar.network.out' : 'SAR-network',
  'sar.paging.out' : 'SAR-paging',
  'sar.queue.out' : 'SAR-queue',
  'sar.sock.out' : 'SAR-sock',
  'sar.swapping.out' : 'SAR-swapping',
  'sar.switching.out' : 'SAR-switching',
  'sar.tcp.out' : 'SAR-tcp'
}

[zhenyun]

I believe it is a compatibility - "stat collector" package once output 'procvmstat.out', later it is changed to 'proc.vmstat.out'. We should consider removing the 3 lines sometime.