hopscotch icon indicating copy to clipboard operation
hopscotch copied to clipboard

Calculate arrow offset without border

Open Spenhouet opened this issue 7 years ago • 2 comments

Fixing issue: #325

Minimal example: http://fiddle.jshell.net/x62303x6/

Changes the arrow offset calculation to be calculated without border since the arrow is moved relative to the content bubble.

el.offsetWidth & el.offsetHeight => width + padding + border el.clientWidth & el.clientHeight => height + padding

Therefor use clientWidth & clientHeight for the arrow offset instead of offsetWidth & offsetHeight.

Spenhouet avatar Mar 21 '17 16:03 Spenhouet

@zimmi88 I don't know why the tests failed. I tried to merge the changes from the master into this pull request. Not sure if something went wrong there. My changes are very small. Maybe you could take a look at it and merge this pull request.

Spenhouet avatar Jun 06 '17 13:06 Spenhouet

Doesn't look like this failure is due to the change. Nonetheless, I'd like to figure out why the build is failing. Time permitting, I'll dig into this.

timlindvall avatar Jun 06 '17 21:06 timlindvall