hopscotch icon indicating copy to clipboard operation
hopscotch copied to clipboard

Event listeners not working

Open RomeroDiver opened this issue 8 years ago • 0 comments

Hi, there is this small bug that I found - when you add a e.g. show callback to a step, and then define a tour onShow callback or add show event to hopscotch, those callbacks won't be called. I found out that the reason for this is invokeEventCallbacks private method:

if (stepCb) {
    return this.invokeCallback(stepCb);
 }

Basically, if step has a callback, then return the result of that callback and don't go further - and further we have the for loop calling other callbacks(e.g. from events or tour's callback).

Am I right here or am I missing something?

RomeroDiver avatar Jul 29 '16 12:07 RomeroDiver