LimeSurvey
Fixed issue #18243: ARIA Attribute role on Array question not correct
Don't ask mle to review something i'm not OK.
Else : if you have a aria-labelledby : you need a role=group
Need more work
I test a solution with role="presentation" currently :
But with this one : https://validator.w3.org/nu/?doc=https%3A%2F%2Fdemo.sondages.pro%2F464896%3Fnewtest%3DY%26lang%3Dfr Error: The role attribute must not be used on a tr element which has a table ancestor with no role attribute, or with a role attribute whose value is table, grid, or treegrid. then : remove the role="radiogroup" on each line. Then : need fieldset for a11Y …
Alt solution : https://demo.sondages.pro/49728?newtest=Y&lang=fr#
role="presentation" for table, remove all thead and th to have really a table deicated to presentation. @c-schmitz can you ask ?
If I am right, the issues reported on that image are not items updated on this ticket.
If I am right, the issues reported on that image are not items updated on this ticket.
Without this fix : there are no issue because table ancestor have role="group" attribute :)
Only appear after this fix : because you directly remove the role="group"
I replace by role="presentation" in https://github.com/LimeSurvey/LimeSurvey/pull/2512
If I am right, the issues reported on that image are not items updated on this ticket.
Without this fix : there are no issue because table ancestor have role="group" attribute :)
Only appear after this fix : because you directly remove the role="group"
OK, I got it.
I replace by role="presentation" in #2512
OK... I think you did more than that :) I would have just stopped there on replacing with role = presentation Was the other part needed right now?
OK... I think you did more than that :) I would have just stopped there on replacing with role = presentation Was the other part needed right now?
Yes … because with role="presentation" : you must remove th and thead for WCAG (the issue about script and sureytheme cc @tpartner ) . Validator throw error about invalid th…
(and for RGAA (french) : you must remove col too … but i realy can not remove col (for width))
you must remove th and thead for WCAG
Can that be done a on a question theme?
you must remove th and thead for WCAG
Can that be done a on a question theme?
Or in an "accessible" survey theme. (at least until 6.x)
Find the issue : https://www.w3.org/TR/WCAG20-TECHS/F92.html
you must remove th and thead for WCAG
Can that be done a on a question theme?
Yes and no … it can be done in SurveyTheme : but then : next time a fix was done in core : theme is broken. It's the reason i don't want to do it for SkelVanilla but on user theme OR core …
Or in an "accessible" survey theme. (at least until 6.x)
It's clearly already awfull to maintain skelvanilla to have 3.X and 5.X compatibility . I don't do it for skelvanilla (except on a specific fork)
I show to Gabriel and Oll where to update the theme.
Else about :
next time a fix was done in core : theme is broken.
See with columns relevance system … broken in updated theme if you update this part.