lilypad icon indicating copy to clipboard operation
lilypad copied to clipboard

Configuration update for Arbitrum

Open arsen3d opened this issue 1 year ago • 12 comments
trafficstars

Glance - superficial check (from domain experts)

Summary

Deploys LP contracts to local l2 Arbitrum Node, Arbitrum Sepolia, Arbitrum One or Arbitrum Nova

How to test locally

./stack chain-deploy dev_personal local l2 dev node must be setup https://docs.arbitrum.io/run-arbitrum-node/run-local-dev-node

arsen3d avatar May 24 '24 17:05 arsen3d

@arsen3d can you please review this document: https://www.notion.so/lilypadnetwork/Git-flow-conventions-98606ed2291b45fba6916dbf6ccab98f, it outlines the naming conventions we should follow for branches and the conventions for git commit messages

AquiGorka avatar May 24 '24 20:05 AquiGorka

Thanks


From: Gorka Ludlow @.> Sent: Friday, May 24, 2024 1:17 PM To: Lilypad-Tech/lilypad @.> Cc: arsen3d @.>; Mention @.> Subject: Re: [Lilypad-Tech/lilypad] Configuration update for Arbitrum (PR #122)

@arsen3dhttps://github.com/arsen3d can you please review this document: https://www.notion.so/lilypadnetwork/Git-flow-conventions-98606ed2291b45fba6916dbf6ccab98f, it outlines the naming conventions we should follow for branches and the conventions for git commit messages

— Reply to this email directly, view it on GitHubhttps://github.com/Lilypad-Tech/lilypad/pull/122#issuecomment-2130294172, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AACIZ664RZWDBJZA6XD4IM3ZD6N5BAVCNFSM6AAAAABIH7IKMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZQGI4TIMJXGI. You are receiving this because you were mentioned.Message ID: @.***>

arsen3d avatar May 24 '24 20:05 arsen3d

Glance - superficial check (from domain experts)

Summary

Deploys LP contracts to local l2 Arbitrum Node, Arbitrum Sepolia, Arbitrum One or Arbitrum Nova

How to test locally

./stack chain-deploy dev_personal local l2 dev node must be setup https://docs.arbitrum.io/run-arbitrum-node/run-local-dev-node

@AquiGorka Deployment documentation has been added.

arsen3d avatar May 31 '24 22:05 arsen3d

@arsen3d hopefully this is helpful- when using Arbitrum, Ive noticed that tx fees on Arbitrum Nova are typically far lower than on Arb One.

galaxyxtwo avatar Jun 03 '24 15:06 galaxyxtwo

@arsen3d hopefully this is helpful- when using Arbitrum, Ive noticed that tx fees on Arbitrum Nova are typically far lower than on Arb One.

The fee issue was in context of testnet. But you are right, Nova is a better deal.

arsen3d avatar Jun 03 '24 15:06 arsen3d

This looks great, nice helpful guide! Left a few initial comments. Will keep testing this once I get funds from a faucet into my wallet.

🙊 https://faucet-testnet.lilypad.tech/

AquiGorka avatar Jun 06 '24 13:06 AquiGorka

@arsen let's rebase and update this PR before merging, there's a couple of outstanding comments to be addressed

AquiGorka avatar Jun 19 '24 13:06 AquiGorka

@AquiGorka, not sure what needs to be done to complete this pull request. Does it require you approval?

arsen3d avatar Jun 20 '24 05:06 arsen3d

There's 2 things that have not been addressed:

  • [ ] we do not need the configurations forarbitrumOne nor arbitrumNova and the configuration for arbitrumSepolia is not needed as we've already added a testnet configuration.
  • [ ] It seems there is a new file: pkg/web3/bindings/pow/pow.go added in this PR which I don't understand how it relates to these changes, can you clarify or remove the file?

With these 2 things addressed I'll approve for us to merge.

AquiGorka avatar Jun 20 '24 13:06 AquiGorka

@alvin-reyes this PR aimed at documenting the deploy to arbitrum process, can you also take over here? You can decide whether to use this PR as base or close and open up a new PR with any documentation that should be part of the code base.

AquiGorka avatar Jul 11 '24 16:07 AquiGorka

@arsen3d. Re-assigning this to @kquirapas so you can work on the phase 1.2 incentivenet improvement.

alvin-reyes avatar Aug 24 '24 20:08 alvin-reyes

Added to engineering board assigned to me

kquirapas avatar Aug 27 '24 01:08 kquirapas