Revision `callbacks.data_monitor`

[luca-medeiros]

What does this PR do?

Part of https://github.com/Lightning-AI/lightning-bolts/issues/839

• [X] pl_bolts.callbacks.data_monitor.DataMonitorBase
• [X] pl_bolts.callbacks.data_monitor.ModuleDataMonitor
• [X] pl_bolts.callbacks.data_monitor.shape2str
• [X] pl_bolts.callbacks.data_monitor.TrainingDataMonitor

Minor changes only. Readability, small performance improvement, typehints Feedback is welcomed 😃

Before submitting

• [X] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• [X] Did you read the contributor guideline, Pull Request section?
• [X] Did you make sure your PR does only one thing, instead of bundling different changes together?
• [X] Did you make sure to update the documentation with your changes?
• [ ] Did you write any new necessary tests? [not needed for typos/docs]
• [X] Did you verify new and existing tests pass locally with your changes?
• [ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

• [X] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[otaj]

Hi @luca-medeiros, do you plan to continue on this PR? Thanks :zap:

[luca-medeiros]

@otaj Hey Otaj, I'll fix it soon and commit the changes.

[luca-medeiros]

Some stuff to do left. Comet logger, multiple (list) loggers, update tests

[Borda]

@luca-medeiros how is it going here? :rabbit:

[Borda]

@luca-medeiros seems that calls are completely missing:

FAILED tests/callbacks/test_data_monitor.py::test_base_log_interval_override - AssertionError: assert 0 == (3 * 2)
FAILED tests/callbacks/test_data_monitor.py::test_base_log_interval_fallback[1-5-5] - AssertionError: assert 0 == (5 * 2)
FAILED tests/callbacks/test_data_monitor.py::test_base_log_interval_fallback[2-5-2] - AssertionError: assert 0 == (2 * 2)
FAILED tests/callbacks/test_data_monitor.py::test_base_log_interval_fallback[5-5-1] - AssertionError: assert 0 == (1 * 2)

[luca-medeiros]

@Borda Hi Jirka, will check it later this weekend. Any news about bolts that I should know about in order to proceed with this PR? Cheers

[Borda]

Any news about bolts that I should know about in order to proceed with this PR?

going to make release 0.7.0 today and then we can continue with improvements, lets sync on Slack :chipmunk: