tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

add ipynb - trainer flags

Open Borda opened this issue 3 years ago • 3 comments

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [x] Did you make sure to update the docs?
  • [x] Did you write any new necessary tests?

What does this PR do?

adding https://github.com/PyTorchLightning/pytorch-lightning/blob/master/notebooks/05-trainer-flags-overview.ipynb

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Borda avatar May 28 '21 22:05 Borda

Hello @Borda! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 441:121: E501 line too long (132 > 120 characters) Line 479:121: E501 line too long (123 > 120 characters) Line 802:121: E501 line too long (131 > 120 characters) Line 1192:1: E402 module level import not at top of file Line 1272:1: E402 module level import not at top of file Line 1291:1: E402 module level import not at top of file Line 1415:1: E402 module level import not at top of file Line 1426:1: E402 module level import not at top of file Line 1462:1: E402 module level import not at top of file Line 1476:1: E402 module level import not at top of file Line 1588:1: E402 module level import not at top of file

Comment last updated at 2021-07-27 21:56:54 UTC

pep8speaks avatar Jun 15 '21 19:06 pep8speaks

@aribornstein shall we get this notebook without running it or just reduce to GPU usage?

Borda avatar Jun 15 '21 19:06 Borda

Was this notebook just transcribed directly from the video? There are a lot of spurious commas and very long sentences. Also, it's a bit weird that the text says "in this video" a lot when it's a notebook / tutorial haha. @Borda Are these grammar corrections and stuff in scope for this PR?

not sure, I took it from our PL repo, maybe @edenlightning could bring some light?

Borda avatar Jul 13 '21 22:07 Borda