tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

Allow PR with notebooks

Open Borda opened this issue 4 years ago • 1 comments

🚀 Feature

Simplify the user work such as passing the notebooks and we would internally convert to scripts and cleaned formating

Motivation

Less user flustration and smoother user experience as performing review in https://www.reviewnb.com

Alternatives

Add extra workflows to handle these situations

  • these notebooks will go to another branch staging
  • on PR to this special branch we run standard notebooks testing
  • on merge (commit to staging) we trigger converting to script and merge to main or create a new PR? (we new PR we have extra level safety and also most likely no actions will be triggered on bots merge event)
  • ISSUE: how to ensure that in the staging branch is only one notebook - after converting we re-create blank staging from main

Additional context

@edgarriba is not happy about converting notebooks to script and fixing issues on his own :P

Borda avatar Jun 14 '21 10:06 Borda

++1 ReviewNB :)

edgarriba avatar Jun 14 '21 10:06 edgarriba