tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

FSD50K Speech Model Fine-tuning Tutorial

Open FlorentMeyer opened this issue 3 years ago • 7 comments

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [x] Did you make sure to update the docs?
  • [ ] Did you write any new necessary tests?

What does this PR do?

Add FSD50K Speech Model Fine-tuning Tutorial.

PR review

Did you have fun?

A lot 🙃

FlorentMeyer avatar Oct 22 '22 15:10 FlorentMeyer

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70%. Comparing base (49d57e9) to head (22000ef).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #201   +/-   ##
===================================
  Coverage    70%    70%           
===================================
  Files         2      2           
  Lines       413    413           
===================================
  Hits        291    291           
  Misses      122    122           

codecov[bot] avatar Oct 22 '22 15:10 codecov[bot]

hey @FlorentMeyer, mind check the file you uploaded, looks like it's too big and there might be some redundant stuff here. Might clean it up?

rohitgr7 avatar Oct 23 '22 19:10 rohitgr7

not sure what happen but GH does not want to show me the diff :/

Borda avatar Oct 25 '22 20:10 Borda

Good evening,

I should mention that the code in the converted notebook was exactly the same as in this Colab notebook (having removed the !pip installs). I also kept the output, but reading other people's examples I suppose that the outputs printed inside the docs are the ones obtained by running the .py converted notebooks on your side.

My last commit therefore makes these changes to the linked Colab notebook:

  • remove all cells outputs
  • remove conditions on bash instructions (a single bash command inside an if was causing a syntax error due to the absence of Python code)
  • remove %% magic
  • comment out the tensorboard cell (which was responsible for creating such a large file, I am sorry I hadn't checked it before)

Changes to the .yaml file:

  • add gdown as a requirement
  • remove brackets around my name (didn't know they were special characters)

I'm just not sure whether the Pandas dataframes with the audio players will get rendered.

FlorentMeyer avatar Oct 26 '22 17:10 FlorentMeyer

I see there are still problems with:

  1. the git+<my_repo> in requirements.txt
  2. the building of the docs saying some cells are missing IDs even though I used jupytext as requested

FlorentMeyer avatar Nov 07 '22 14:11 FlorentMeyer

OK I also saw that there were bizarre things happening in the notebook, looks like the pre-commit hooks are moving stuff around causing duplication every time I pull them into my own code before being able to push again (example) and it's easy to miss things when reading a notebook as a .py file.

Anyway I read the whole file carefully and this should be fixed now. Also all cells have an ID so I'm not sure where the "cells are missing IDs" error comes from :/

FlorentMeyer avatar Nov 07 '22 16:11 FlorentMeyer

Small up!

FlorentMeyer avatar Dec 01 '22 13:12 FlorentMeyer

seem the repo https://github.com/FlorentMeyer/fsd50k_speech_model_finetuning and this example is silent since 2022, so let's close it for now, but feel free to reopen any time :flamingo:

Borda avatar Jul 26 '24 10:07 Borda